[RFC PATCH 17/35] Segment register changes for Xen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Wright wrote:
> 1. We clear FS/GS before changing TLS entries and switching LDT, as
> otherwise the hypervisor will fail to restore thread-local values on
> return to the guest kernel and we take a slow exception path.

> @@ -647,6 +647,8 @@ struct task_struct fastcall * __switch_t
>  	 */
>  	savesegment(fs, prev->fs);
>  	savesegment(gs, prev->gs);
> +	clearsegment(fs);
> +	clearsegment(gs);
>   

Really not needed.  Think about it.  You can even speed up Xen.  I'm 
glad the native operation here is a nop, but it should be 
hypervisor_clearsegment or xen_clearsegment if you really want to keep it.

Zach

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux