* Andi Kleen <ak@xxxxxx> wrote: > > * This grunge runs the startup process for > > * the targeted processor. > > */ > > + cpu_gdt_descr[cpu].address = __get_free_page(GFP_KERNEL|__GFP_ZERO); > > I can see why don't check it for NULL, but it's a ugly reason and > would be better fixed. It at least needs a comment. it's so early in the bootup that any failure here would probably be fatal anyway. But yeah, a comment would be nice. > -Andi (who would still prefer just going back to the array in head.S - > would work as well and waste less memory) that doesnt really solve the problem for e.g. Xen, which needs a separate page for each GDT. (xenolinux is a separate arch right now, but it will/should be merged back into its base architectures) So why not solve all the problems at once? Ingo
