[PATCH 4/14] i386 / Clean up asm and volatile keywords in desc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andi Kleen wrote:
> On Wed, Aug 10, 2005 at 09:53:51PM -0700, zach@xxxxxxxxxx wrote:
> 
>>Stop using extra underscores on asm and volatiles, that is just silly.
> 
> Actually the volatiles might be still useful. Or if you drop them
> at least add memory clobbers. I had sometimes bugs  on x86-64
> with the compiler moving such assembly statements with invisible 
> side effects around too aggressively and causing weird problems.
> 
> Agreed on the underscores, I hate them too :)
> 

Well, put volatiles in *unless* the only effect of an asm statement is 
producing the output values.

	-hpa


[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux