On Thu, Dec 19, 2013 at 05:33:09PM -0000, David Laight wrote: > > > These warning are non-default GCC warnings. These can be seen either > > > by adding W=1 while running make (i.e. make W=1) or adding > > > -Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile. > > > > By default, we don't care about 'W=1' warnings, as no one sees them, and > > they don't matter. > > -Wmissing-prototypes really ought to be defined. Yeah, that's the plan; this volume of patches should make it sufficiently low-noise to allow turning it on by default. > Some of the other warning are a little more pedantic, the most annoying > is -Wsign-compare. OTOH a lot of code out there is clean enough to build > without any warnings and with a moderate amount of pedantry from the compiler. > > OTOH just including extra headers isn't ideal - it can considerably > slow down the compilation time. There are many subsystems that don't > really separate their internal headers from their external ones. There's a benefit to doing so, though: it ensures that the prototypes in the header stay in sync with the definition. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
