RE: [PATCH v2 12/12] libusbg: Replace directory names with defines.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Krzysztof Opasiak
> Replace strings, functions, configs strings placed
> everywhere in code with macro defintions STRINGS_DIR,
> FUNCTIONS_DIR and CONFIGS_DIR.

I'm not convinced this is an improvement, do you have a further
change in mind?
It also isn't entirely clear there aren't some other subtle
changes to the generated strings.

More important would be to replace all the sprint() calls
with snprintf() and and (probably) check for truncation before
using the strings as pathnames.

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux