Hi, On Wed, Dec 18, 2013 at 05:33:52PM +1100, Stephen Rothwell wrote: > > > > > > > both isp1301-omap and fsl_usb2_otg drivers > > > > > > > depend on usb_bus_start_enum() which is only > > > > > > > defined if CONFIG_USB != n. There is a problem, > > > > > > > however, where both those drivers could be > > > > > > > statically linked, while CONFIG_USB=m. > > > > > > > > > > > > > > Fix the problem by fixing driver dependency. > > > > > > > > > > > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > > > > > > --- > > > > > > > > > > > > > > Greg, I'll send this to you in a pull request > > > > > > > tomorrow. > > > > > > > > > > > > I can take this as-is right now if you want me to, no need for a full > > > > > > pull request, I still do take patches :) > > > > > > > > > > > > Just let me know, > > > > > > > > > > please go ahead, I don't think I'll have any other important fixes for > > > > > this -rc. (famous last words). > > > > > > > > Gentle ping on this patch, we still have build errors on randconfig due > > > > to lack of this patch in mainline. > > > > > > Ick, sorry, it got lost in my travels, I'll go get to this right now... > > > > Thanks Greg. > > I am still getting this error despite your patch being in the tree ... are you sure that patch is included ? I have just checked on greg/usb-linus that it's impossible to make CONFIG_USB=m and CONFIG_ISP1301_OMAP=y (same for the other phy driver from Freescale). I can also build omap1_defconfig with all possibilities for CONFIG_USB + CONFIG_ISP1301_OMAP, that is: N-N, M-M, Y-M. If you can still see the problem, then send me your .config and error messages. You could be seeing another problem. cheers -- balbi
Attachment:
signature.asc
Description: Digital signature
