On Mon, Dec 16, 2013 at 09:20:20PM +0000, Paul Zimmerman wrote: > > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Felipe Balbi > > Sent: Monday, December 16, 2013 11:42 AM > > > > By making that configurable on Kconfig, we won't > > need to modify source code when we want to change > > the way f_mass_storage behaves for a specific > > product. > > Shouldn't this value also be configurable via module params / sysfs, > the same way that USB_GADGET_STORAGE_NUM_BUFFERS is? I know new module > parameters are frowned upon, but the mass storage gadget has quite a > few of them already, so for consistency I think this one should be too. > > Plus, in my experience, this value is the one that needs tuning for > performance, while NUM_BUFFERS is fine with its default value. So if > NUM_BUFFERS is allowed to be configured at runtime, this one should be > too. I have no problems with that. Let's see what Michal and Alan think. What do you guys think ? -- balbi
Attachment:
signature.asc
Description: Digital signature
