Re: [PATCH 1/2] usb: dwc3: gadget: always enable IOC on bulk/interrupt transfers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 16, 2013 at 01:41:42PM -0600, Felipe Balbi wrote:
> by setting IOC always, we can recycle TRBs a
> lot sooner at the expense of some increased
> CPU load.
> 
> The extra load seems to be quite minimal on
> OMAP5 devices (instead of 1 IRQ for one MSC
> transfer, we get
> CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS).
> 
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
>  drivers/usb/dwc3/gadget.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 5401b2b..4d72152 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -778,7 +778,8 @@ static void dwc3_prepare_one_trb(struct dwc3_ep *dep,
>  
>  	case USB_ENDPOINT_XFER_BULK:
>  	case USB_ENDPOINT_XFER_INT:
> -		trb->ctrl = DWC3_TRBCTL_NORMAL;
> +		trb->ctrl = DWC3_TRBCTL_NORMAL
> +			| DWC3_TRB_CTRL_IOC;

maybe this should be conditional on !req->no_interrupt ??

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux