Re: [PATCH] usb: gadget: nokia: fix error recovery path for optional functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/13/2013 02:46 PM, Andrzej Pietrasiewicz wrote:
> diff --git a/drivers/usb/gadget/nokia.c b/drivers/usb/gadget/nokia.c
> index 0a8099a..3ab3861 100644
> --- a/drivers/usb/gadget/nokia.c
> +++ b/drivers/usb/gadget/nokia.c
> @@ -126,9 +126,9 @@ static int __init nokia_bind_config(struct usb_configuration *c)
>  	struct usb_function *f_ecm;
>  	struct usb_function *f_obex2 = NULL;
>  	int status = 0;
> -	int obex1_stat = 0;
> -	int obex2_stat = 0;
> -	int phonet_stat = 0;
> +	int obex1_stat = -1;
> +	int obex2_stat = -1;
> +	int phonet_stat = -1;

I haven't look at the whole context but please do -ENODEV or something
like that but don't do -1.

>  	if (!IS_ERR(fi_phonet)) {
>  		f_phonet = usb_get_function(fi_phonet);
> 

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux