Thanks for the quick response. I think we can use the extcon framework for our events. The usb_phy_vbus_on/off() can probably be handled with the extcon events. Right now we register gadget->vbus_draw with our usb_phy_set_power(). I don't see how the generic phy handles this. Also we use usb_phy_set_suspend() since we completely power off our usb core/phy and wait for an external interrupt to notify the phy of activity on the bus. We want to put the phy into a suspend state based on a suspend event from the usb core. Thanks, Graham -----Original Message----- From: Kishon Vijay Abraham I [mailto:kishon@xxxxxx] Sent: Wednesday, December 11, 2013 9:21 PM To: Graham Williams Cc: linux-usb@xxxxxxxxxxxxxxx Subject: Re: Generic phy framework Hi, On Thursday 12 December 2013 03:27 AM, Graham Williams wrote: > Hi Kishon, > > I see you have added this new generic phy framework. The usb phy framework contains a struct notifier_block to send usb specific events like USB_EVENT_ID. Will this new generic phy support notifications like the usb phy? Also will set_power() and set_vbus() ops get added? Or should we continue to use the usb_phy as well as the generic phy? For events, ideally you should be using the extcon framework. For any new drivers you should be using the generic PHY. If you can tell us how those ops are used, we can think of adding it in Generic PHY. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
