On Tue, Dec 10, 2013 at 03:08:02PM -0800, Sarah Sharp wrote: > On Mon, Dec 09, 2013 at 12:42:48PM +0100, Takashi Iwai wrote: > > It makes easier for debugging some hardware specific issues. > > > > Note that this option won't override the value to be set. That is, > > you can turn quirks on by this option but cannot turn them off if set > > by the driver. > > > > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx> > > --- > > > > I noticed the lack of quirks module option during investigating the > > recent bug report for my Haswell S5 fix quirk > > https://bugzilla.kernel.org/show_bug.cgi?id=66171 > > Hi Takashi, > > We're trying to get away from adding new module parameters in general. > > However, I do I think this module parameter would be highly useful. It > means we can ask bug reporters to reload the xhci_hcd module with a > quirk instead of forcing them to recompile their driver. > > I also don't really see a good way to allow users to change the quirks > without a module parameter. We can't really add a way to manipulate the > quirks through sysfs or debugfs, because most of the quirks code assumes > quirks are set at module load. Modifying the existing 18 quirks to be > able to be turned on or off on the fly would be difficult to implement > and test, considering I don't have access to most of the hardware the > quirks were enabled for. > > Greg, thoughts on this? I have no objection to this, it lets people test things out without having to rebuild their kernel, always a good thing. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
