On Monday 09 December 2013 09:54 PM, Balbi, Felipe wrote: > Hi, > > On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote: >> + ret = usb_add_phy_dev(&k_phy->usb_phy_gen.phy); >> + if (ret) >> + return ret; >> + k_phy->usb_phy_gen.phy.init = keystone_usbphy_init; >> + k_phy->usb_phy_gen.phy.shutdown = keystone_usbphy_shutdown; > > this *must* be initialized before adding the PHY to the subsystem. So > these two lines must be moved before usb_add_phy_dev(). > Make sense. Probably its good idea to repost the $subject patch with above as well as other delay related comment. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html