Hi again,
On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote:
> +static int keystone_usbphy_init(struct usb_phy *phy)
> +{
> + struct keystone_usbphy *k_phy = dev_get_drvdata(phy->dev);
> + u32 val;
> +
> + val = keystone_usbphy_readl(k_phy->phy_ctrl, USB_PHY_CTL_CLOCK);
> + keystone_usbphy_writel(k_phy->phy_ctrl, USB_PHY_CTL_CLOCK,
> + val | PHY_REF_SSP_EN);
you need to enable this device's clock to access its registers right ?
> + udelay(20);
why the magic 20 usecs ? Where does that come from ? Empirically found
or is there a documentation reference ? At least add a comment there.
--
balbi
Attachment:
signature.asc
Description: Digital signature
