RE: [PATCH 2/4 V2] ARM: mx28: Add USB PHY overcurrent pinmux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




 
> 
> The GPIO is working for this pin. But also the DIGCTL register bits
> helped here.  Now the OC event triggers if the pin gets pulled to 3V3.
> 
> I am currently looking for a good place to enable the DIGCTL bits.
> I suggest to enable them per default.  As we don't have USBMISC registers
> in MX28, the bits should be toggled in ci_hdrc_imx.c if the of property
> "disable-overcurrent" is not found.  I will use the syscon interface to
> reach them with the regmap interface.
> 

Hi Michael,

usbmisc register doesn't stand for the register needs to be in usb controller.
Any registers which are related to USB function can be considered as usbmisc
registers. You will see FSL-style SoC, the over-current or other related setting
are at controller base + 0x800 (0x600), but Sigmatel-style SoC (mx28/mx23), the usb
register are not at controller register region.

My suggestion is: create usbmisc node for mx28, and put oc setting at there, it can
keep ci_hdrc_imx.c clean.
Besides, you may need two dts user setting for oc enable and oc polarity.

Peter


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux