Hi, On Thu, Nov 21, 2013 at 06:40:10PM +0800, Yingchun Li wrote: > hi, > if musb bulk_split is enable, the segment size will be set according > to hw_ep->max_packet_sz_tx, and the segment will be writen to fifo. > But after the first tranfser end, the segment size will be set no larger > than qh->maxpacket (in musb_host_tx),and the bluk_split make no sense. > so please check the following patch, I have tested it on my board. > > diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c > index 6582a20..f251132 100644 > --- a/drivers/usb/musb/musb_host.c > +++ b/drivers/usb/musb/musb_host.c > @@ -1455,8 +1455,8 @@ done: > * (and presumably, FIFO is not half-full) we should write *two* > * packets before updating TXCSR; other docs disagree... > */ > - if (length > qh->maxpacket) > - length = qh->maxpacket; > + if (length > qh->segsize) > + length = qh->segsize; please read Documentation/SubmittingPatches and Documentation/CodingStyle and resend your patch in proper format. Also, please run your patches through scripts/checkpatch.pl --strict You shouldn't see any errors or warnings from checkpatch.pl. -- balbi
Attachment:
signature.asc
Description: Digital signature
