Re: [PATCH 5/5] usb: musb: dsps: indentation and whitespace fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 25, 2013 at 08:39:53PM +0100, Daniel Mack wrote:
> Just a cosmetic thing, no functional change.
> 
> Signed-off-by: Daniel Mack <zonque@xxxxxxxxx>
> ---
>  drivers/usb/musb/musb_dsps.c | 23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> index 361ddf8..b27c072 100644
> --- a/drivers/usb/musb/musb_dsps.c
> +++ b/drivers/usb/musb/musb_dsps.c
> @@ -131,9 +131,9 @@ struct dsps_context {
>  struct dsps_glue {
>  	struct device *dev;
>  	struct platform_device *musb;	/* child musb pdev */
> -	const struct dsps_musb_wrapper *wrp; /* wrapper register offsets */
> +	const struct dsps_musb_wrapper *wrp;	/* wrapper register offsets */
>  	struct timer_list timer;	/* otg_workaround timer */
> -	unsigned long last_timer;    /* last timer data for each instance */
> +	unsigned long last_timer;	/* last timer data for each instance */
>  
>  	struct dsps_context context;
>  };
> @@ -213,7 +213,7 @@ static void dsps_musb_disable(struct musb *musb)
>  
>  	dsps_writel(reg_base, wrp->coreintr_clear, wrp->usb_bitmap);
>  	dsps_writel(reg_base, wrp->epintr_clear,
> -			 wrp->txep_bitmap | wrp->rxep_bitmap);
> +		    wrp->txep_bitmap | wrp->rxep_bitmap);

quite frankly, I don't what checkpatch.pl is trying to force here. I
much prefer a tab-only indentation, matching with ( characters forces us
to add some spaces. I would rather not take this patch.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux