Re: [PATCH v5 0/3] usb: ehci+chipidea: fix imx28 "ENGR119653 USB: ARM to USB register error issue"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 22, 2013 at 10:53:53AM +0100, Marc Kleine-Budde wrote:
> Hello,
> 
> this series implements the suggested workaround for freescale's imx28 Errata,
> "ENGR119653 USB: ARM to USB register error issue".
> 
> changes since v4:
> - fix signature of imx28_ehci_writel(), don't use volatile, make use of __iomem

The __iomem is just sparse thing, and not related to gcc, our imx28_ehci_writel
uses assembly directly, and not call writel any more. The definition of
__raw_writel still uses volatile:

include/asm-generic/io.h:
static inline void __raw_writel(u32 b, volatile void __iomem *addr)
{
	        *(volatile u32 __force *) addr = b;
}

> - avoid new #ifdef by using if (IS_ENABLED())
> 
> Marc
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux