Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2013/11/21 Grant Grundler <grundler@xxxxxxxxxx>:
> On Wed, Nov 20, 2013 at 11:32 AM, Grant Grundler <grundler@xxxxxxxxxx> wrote:
>> Seems like this should be part of usbnet_resume code based on whether
>> the driver provides mdio_write hook (most USBNET drivers do).
>
> Just to be clear: I don't think this is feasible for the now obvious
> reason that not all device lose phy stat on resume. :/
>
> Freddy sent me a patch that saves/restores MII_ADVERTISE and MII_BMCR
> registers. Testing that now and he'll post if that all works out.

That should be enough to ensure the PHY is put back into a consistent
state. So long as you are suspending/resuming from a configuration
where autoneg was enabled, I would not expect anything bad to happen.
If the link was forced, that is a different story.

One way to make sure this work properly without driver-specific code
is to include that functionality into the PHY library. As far as I can
see it the asix drivers do not use it but implement the old-style
mii_bus interface so that would be a first step.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux