[PATCH] usb: phy: am335x: Prevent GPIO reset line request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The 'gpio_reset' field was implicitly set to zero, which is a valid
GPIO line and results in the NOP PHY layer trying to request it.

Instead, the AM335x SoC need special USB PHY reset handling so let's
set 'gpio_reset' to EINVAL and prevent the NOP PHY from messing with it.

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxxxxxxxxxx>
---
Commit bd27fa44e13830d2baa278d5702e766380659cb3 (usb: phy: generic:
Don't use regulator framework for RESET line) introduced this.

 drivers/usb/phy/phy-am335x.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c
index 6370e50..7fff9f3 100644
--- a/drivers/usb/phy/phy-am335x.c
+++ b/drivers/usb/phy/phy-am335x.c
@@ -43,6 +43,9 @@ static int am335x_phy_probe(struct platform_device *pdev)
 	if (!am_phy)
 		return -ENOMEM;
 
+	/* Prevent GPIO Reset from the Generic PHY */
+	am_phy->usb_phy_gen.gpio_reset = -EINVAL;
+
 	am_phy->phy_ctrl = am335x_get_phy_control(dev);
 	if (!am_phy->phy_ctrl)
 		return -EPROBE_DEFER;
-- 
1.8.1.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux