On 11/15/2013 09:38 PM, Aaro Koskinen wrote:
> Commit bd27fa44e13830d2baa278d5702e766380659cb3 (usb: phy: generic:
> Don't use regulator framework for RESET line) introduced regression: All
> users of usb_nop_xceiv_register() will fail because there is no platform
> data and the default reset GPIO is 0 which is a valid GPIO. Fix that.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
Acked-by: Roger Quadros <rogerq@xxxxxx>
> ---
> drivers/usb/phy/phy-generic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
> index fce3a9e..834dc98 100644
> --- a/drivers/usb/phy/phy-generic.c
> +++ b/drivers/usb/phy/phy-generic.c
> @@ -252,6 +252,8 @@ static int usb_phy_gen_xceiv_probe(struct platform_device *pdev)
> clk_rate = pdata->clk_rate;
> needs_vcc = pdata->needs_vcc;
> nop->gpio_reset = pdata->gpio_reset;
> + } else {
> + nop->gpio_reset = -1;
> }
>
> err = usb_phy_gen_create_phy(dev, nop, type, clk_rate, needs_vcc);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
