Re: [PATCH 32/68] uas: Use proper packet size when submitting reponse urbs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 11/18/2013 08:05 AM, Gerd Hoffmann wrote:
On Fr, 2013-11-15 at 16:06 +0100, Hans de Goede wrote:
task management commands expect a response_iu rather then a sense_iu,
and
these have different sizes. Make the urb we submit to get the reply
the right
size.

I think that doesn't work for uas in usb2 (no streams) mode.  status
urbs are not linked to requests (via tag / stream id) in that case, so
you can't know in advance which status urb gets filles with a sense_ui
and which with a response_ui by the device.

Oh, good point. You're completely right, so we always need to submit the
bigger size which is the sense urb size. I'll drop this patch from my
set then, and send a v3. Before I do that, do you have any other remarks ?

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux