RE: phy-tegra-usb.c: wrong pointer check for remap UTMI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Chris Ruehl [mailto:chris.ruehl@xxxxxxxxxxxx]
> Sent: Monday, November 18, 2013 11:56 AM
> To: linux-usb@xxxxxxxxxxxxxxx; Venu Byravarasu; Greg Kroah-Hartman
> Subject: phy-tegra-usb.c: wrong pointer check for remap UTMI
> 
> 
> While I hunt an other problem with my UPLI I see this problem.
> Linux-next 20131105 source.
> 
> commit bd6a053d0497bc71e182e8a1063a8ae7d803fc7d
> Author: Chris Ruehl <chris.ruehl@xxxxxxxxxxxx>
> Date:   Mon Nov 18 14:21:58 2013 +0800
> 
>      Fix wrong pointer when remap UTMI pad
> 
> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
> index 82232ac..bbe4f8e 100644
> --- a/drivers/usb/phy/phy-tegra-usb.c
> +++ b/drivers/usb/phy/phy-tegra-usb.c
> @@ -876,7 +876,7 @@ static int utmi_phy_probe(struct tegra_usb_phy
> *tegra_phy,
> 
>          tegra_phy->pad_regs = devm_ioremap(&pdev->dev, res->start,
>                  resource_size(res));
> -       if (!tegra_phy->regs) {
> +       if (!tegra_phy->pad_regs) {

Seems to be originated due to copy-paste problem.
Anyhow, thanks for fixing. 

Acked-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx>

>                  dev_err(&pdev->dev, "Failed to remap UTMI Pad regs\n");
>                  return -ENOMEM;
>          }

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux