Hi,
On 11/15/2013 10:07 PM, Greg KH wrote:
On Fri, Nov 15, 2013 at 09:21:40PM +0100, Hans de Goede wrote:
Hi,
On 11/15/2013 08:19 PM, Sarah Sharp wrote:
On Fri, Nov 15, 2013 at 04:06:56PM +0100, Hans de Goede wrote:
Note this is done through a usbcore module parameter as the option is needed
by both the uas and usb-storage drivers.
I'm a bit confused as to why you need both this patch and the previous
patch. The previous patch adds the ability to add an usual dev entry to
the UAS driver to make it not bind to a UAS device (usb-storage would
get used instead). This one adds a module parameter to the USB core to
disable UAS all together.
I believe you can add unusual dev entries via modprobe arguments
For the usb-storage driver that is correct, but not for the uas driver,
the current modprobe / sysfs options are for setting quirks only on the
usb-storage side. uas cannot access these quirk since this info is all
inside the usb-storage module.
Then export it from the usb-storage module, creating a new one if needed
to share the data (or just have uas depend on usb-storage), don't create
a new one in the usb core.
Ok, I'll make uas depend on usb-storage then, in practice this should not
make any difference since plugging in an uas device will cause both drivers
to get loaded anyways.
As Sarah rightly points out, we don't want to add new module parameters
at all if possible, and not for the USB core for something like this,
sorry.
No problem, I'll go and rework this bit of the patchset to make uas use
the quirks from usb-storage, as well as deal with some minor other remarks,
and then send a v2 pull-req to Sarah.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
