Hi,
On 11/15/2013 08:05 PM, Sarah Sharp wrote:
On Fri, Oct 25, 2013 at 07:01:06PM +0100, Hans de Goede wrote:
Hi All,
Here are 2 more patches on top of my patch set of 7 from yesterday. These
add an (empty for now) blacklist, as well as a kernel cmdline option, to
force using usb-storage with devices which advertise uas support so that
we can work around buggy uas devices.
Working on this has also led to me having some questions about uas:
1) The driver has a prototype class id in there, as well as code for
dealing with a device with a fixed ep config. I'm tending towards removing
both. Does any of you know if these are for one and the same device ?
I really believe we should fail the driver probe if the endpoint descriptors
are wrong, rather then assume a fixed config. We could add the fixed config
as a quirk, but we should not blindly use it for all devices with broken
descriptors.
I suspect that code was for some broken prototypes that we were limping
along with, since we couldn't get access to any off the shelf UAS
devices. Feel free to rip out the fixed ep config code.
Ok, I'll send a separate patch for this on top the 68 patches pull-req
I did today.
2) Sarah, you asked me to become maintainer for uas, that is fine, I'll
do a MAINTAINERS patch, should I leave you and Matthew as maintainers, or
shall I remove the both of you ?
Thanks for agreeing to be the maintainer!
Please remove both Matthew and I as maintainers.
Ok I'll also do a separate patch for this (I'll merge them into the relevant
patches if I do a v2 of my pullreq).
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
