On Fri, Nov 15, 2013 at 09:45:16AM +0100, Daniel Mack wrote:
> Include linux/dma-mapping.h to make the new functions available that are
> used since 22d9d8e83 ("DMA-API: usb: use dma_set_coherent_mask()").
>
> Signed-off-by: Daniel Mack <zonque@xxxxxxxxx>
> ---
> I got the following error while building for PXA platforms from Linus'
> current git head:
>
> drivers/usb/host/ohci-pxa27x.c: In function ‘ohci_pxa_of_init’:
> drivers/usb/host/ohci-pxa27x.c:310:2: error: implicit declaration of function ‘dma_coerce_mask_and_coherent’ [-Werror=implicit-function-declaration]
> drivers/usb/host/ohci-pxa27x.c:310:2: error: implicit declaration of function ‘DMA_BIT_MASK’ [-Werror=implicit-function-declaration]
Please put the errors (and warnings) in the commit description; they're
useful documentation for others who may encounter the same problem.
> diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
> index e89ac4d..3963834 100644
> --- a/drivers/usb/host/ohci-pxa27x.c
> +++ b/drivers/usb/host/ohci-pxa27x.c
> @@ -29,6 +29,7 @@
> #include <linux/platform_data/usb-ohci-pxa27x.h>
> #include <linux/platform_data/usb-pxa3xx-ulpi.h>
> #include <linux/platform_device.h>
> +#include <linux/dma-mapping.h>
Please review the #include statements and see if you can spot a broad
pattern there, and then decide whether your placement follows the
established pattern, thanks. :)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
