Re: [RFC 07/21] xhci: fix sparse warning in xhci-trace.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Applied to for-usb-next for 3.14.

Thanks,
Sarah Sharp

On Mon, Sep 09, 2013 at 09:03:12PM +0300, Xenia Ragiadakou wrote:
> This patch fixes the following sparse warnings:
> drivers/usb/host/./xhci-trace.h:116:1: warning: cast to restricted __le32
> drivers/usb/host/./xhci-trace.h:116:1: warning: cast to restricted __le32
> drivers/usb/host/./xhci-trace.h:116:1: warning: restricted __le32 degrades to
> integer
> drivers/usb/host/./xhci-trace.h:116:1: warning: restricted __le32 degrades to
> integer
> 
> by converting the field 'trb' of the trace buffer entry structure from array
> with elements of type __le32 to an array with elements of type u8.
> Into the trb array are copied the contents of the TRB that generated the event.
> The trace-cmd tool with the help of plugin_xhci.py will use this field to
> parse the TRB contents in a human readable way.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> ---
>  drivers/usb/host/xhci-trace.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h
> index 59a0b03..132abda 100644
> --- a/drivers/usb/host/xhci-trace.h
> +++ b/drivers/usb/host/xhci-trace.h
> @@ -121,7 +121,7 @@ DECLARE_EVENT_CLASS(xhci_log_event,
>  		__field(u64, dma)
>  		__field(u32, status)
>  		__field(u32, flags)
> -		__dynamic_array(__le32, trb, 4)
> +		__dynamic_array(u8, trb, sizeof(struct xhci_generic_trb))
>  	),
>  	TP_fast_assign(
>  		__entry->va = trb_va;
> -- 
> 1.8.3.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux