Applied to for-usb-next for 3.14.
Thanks,
Sarah Sharp
On Mon, Sep 09, 2013 at 09:03:10PM +0300, Xenia Ragiadakou wrote:
> This patch converts Event TRB's 3rd field, which has type le32, to CPU
> byteorder before using it to retrieve the Slot ID with TRB_TO_SLOT_ID macro.
> This bug was found using sparse.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> ---
> drivers/usb/host/xhci-ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index af9bbac..faff6fc 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1634,7 +1634,7 @@ static void handle_device_notification(struct xhci_hcd *xhci,
> u32 slot_id;
> struct usb_device *udev;
>
> - slot_id = TRB_TO_SLOT_ID(event->generic.field[3]);
> + slot_id = TRB_TO_SLOT_ID(le32_to_cpu(event->generic.field[3]));
> if (!xhci->devs[slot_id]) {
> xhci_warn(xhci, "Device Notification event for "
> "unused slot %u\n", slot_id);
> --
> 1.8.3.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
