Applied to for-usb-next-queue for 3.14. Sarah Sharp On Mon, Sep 09, 2013 at 09:03:06PM +0300, Xenia Ragiadakou wrote: > The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx > have type __le32 and need to be converted to CPU byteorder before being > used to derive the number of added endpoints. > This bug was found using sparse. > > Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx> > --- > drivers/usb/host/xhci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index 787076e..617d568 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -1880,8 +1880,8 @@ static u32 xhci_count_num_new_endpoints(struct xhci_hcd *xhci, > * (bit 1). The default control endpoint is added during the Address > * Device command and is never removed until the slot is disabled. > */ > - valid_add_flags = ctrl_ctx->add_flags >> 2; > - valid_drop_flags = ctrl_ctx->drop_flags >> 2; > + valid_add_flags = le32_to_cpu(ctrl_ctx->add_flags) >> 2; > + valid_drop_flags = le32_to_cpu(ctrl_ctx->drop_flags) >> 2; > > /* Use hweight32 to count the number of ones in the add flags, or > * number of endpoints added. Don't count endpoints that are changed > -- > 1.8.3.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
