Re: [RFCv4 07/24] ehci: use new dbg_status() unconditionally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2013-11-14 at 11:59 -0500, Alan Stern wrote:
> On Thu, 14 Nov 2013 oliver@xxxxxxxxxx wrote:
> 
> > From: Oliver Neukum <oneukum@xxxxxxx>
> > 
> > With the new dbg_status() the interrupt handler doesn't need
> > conditional compilation
> > 
> > Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>
> > ---
> >  drivers/usb/host/ehci-hcd.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> > index e8ba4c4..9d7838f 100644
> > --- a/drivers/usb/host/ehci-hcd.c
> > +++ b/drivers/usb/host/ehci-hcd.c
> > @@ -714,10 +714,8 @@ static irqreturn_t ehci_irq (struct usb_hcd *hcd)
> >  	cmd = ehci_readl(ehci, &ehci->regs->command);
> >  	bh = 0;
> >  
> > -#ifdef	VERBOSE_DEBUG
> >  	/* unrequested/ignored: Frame List Rollover */
> > -	dbg_status (ehci, "irq", status);
> > -#endif
> > +	dbg_status(ehci, "irq", status);
> 
> I'm undecided about this.  Printing out a status line for _every_ 
> interrupt would be an awful lot.

I'll eliminate it entirely.

	Regards
		Oliver




--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux