Re: [RFCv4 05/24] ehci: no conditional compilation for interestingness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 14 Nov 2013 oliver@xxxxxxxxxx wrote:

> From: Oliver Neukum <oneukum@xxxxxxx>
> 
> The decision about what is interesting is done in user space
> when dynamic debugging is used.
> 
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>
> ---
>  drivers/usb/host/ehci-hub.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> index 835fc08..9b2d0e1 100644
> --- a/drivers/usb/host/ehci-hub.c
> +++ b/drivers/usb/host/ehci-hub.c
> @@ -1114,10 +1114,7 @@ static int ehci_hub_control (
>  		if (test_bit(wIndex, &ehci->port_c_suspend))
>  			status |= USB_PORT_STAT_C_SUSPEND << 16;
>  
> -#ifndef	VERBOSE_DEBUG
> -	if (status & ~0xffff)	/* only if wPortChange is interesting */
> -#endif
> -		dbg_port (ehci, "GetStatus", wIndex + 1, temp);
> +		dbg_port(ehci, "GetStatus", wIndex + 1, temp);
>  		put_unaligned_le32(status, buf);
>  		break;

Like in ohci-hcd, I think it would be better to keep the "if" 
statement.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux