Re: [RFCv4 01/24] ohci: remove conditional compilation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 14 Nov 2013 oliver@xxxxxxxxxx wrote:

> From: Oliver Neukum <oneukum@xxxxxxx>
> 
> Conditional compilation for debugging is removed in favor of
> dynamic debugging. To do so
> 
> 1. the support for debugfs is always compiled
> 2. the support for the ancient print_urb debugging aid is removed
> 
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>

> --- a/drivers/usb/host/ohci-dbg.c
> +++ b/drivers/usb/host/ohci-dbg.c
> @@ -1,3 +1,4 @@
> +
>  /*
>   * OHCI HCD (Host Controller Driver) for USB.
>   *

This hunk looks like a typo.

> --- a/drivers/usb/host/ohci.h
> +++ b/drivers/usb/host/ohci.h

> @@ -487,11 +482,7 @@ static inline struct usb_hcd *ohci_to_hcd (const struct ohci_hcd *ohci)
>  #define ohci_warn(ohci, fmt, args...) \
>  	dev_warn (ohci_to_hcd(ohci)->self.controller , fmt , ## args )
>  
> -#ifdef OHCI_VERBOSE_DEBUG
>  #	define ohci_vdbg ohci_dbg
> -#else
> -#	define ohci_vdbg(ohci, fmt, args...) do { } while (0)
> -#endif
>  
>  /*-------------------------------------------------------------------------*/

Doesn't this belong in the 2/24 patch, where you get rid of ohci_vdbg 
entirely?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux