On Mon, Nov 11, 2013 at 10:37:07PM +0100, Marc Kleine-Budde wrote: > On 10/30/2013 04:06 AM, Peter Chen wrote: > > Due to imx28 needs ARM swp instruction for writing, we set > > CI_HDRC_IMX28_WRITE_FIX for imx28. > > > > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> > > --- > > drivers/usb/chipidea/ci_hdrc_imx.c | 32 ++++++++++++++++++++++++++------ > > 1 files changed, 26 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c > > index 023d3cb..68f7f5e 100644 > > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c > > @@ -23,6 +23,26 @@ > > #include "ci.h" > > #include "ci_hdrc_imx.h" > > > > +#define CI_HDRC_IMX_IMX28_WRITE_FIX BIT(0) > > + > > +struct ci_hdrc_imx_platform_flag { > > + unsigned int flags; > > +}; > > + > > +static const struct ci_hdrc_imx_platform_flag imx27_usb_data = { > > +}; > > + > > +static const struct ci_hdrc_imx_platform_flag imx28_usb_data = { > > + .flags = CI_HDRC_IMX_IMX28_WRITE_FIX, > > +}; > > + > > +static const struct of_device_id ci_hdrc_imx_dt_ids[] = { > > + { .compatible = "fsl,imx28-usb", .data = &imx28_usb_data}, > > + { .compatible = "fsl,imx27-usb", .data = &imx27_usb_data}, > ^^^ > Nitpick, please add ", " or a single space. > Thanks, will change. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html