Hi, On Fri, Nov 01, 2013 at 09:26:41AM +0100, Johannes Stezenbach wrote: > Hi, > > On Thu, Oct 31, 2013 at 10:21:28AM -0500, Felipe Balbi wrote: > > On Thu, Oct 31, 2013 at 04:02:20PM +0100, Johannes Stezenbach wrote: > > > On Wed, Oct 30, 2013 at 10:44:30PM +0100, Johannes Stezenbach wrote: > > > > On Wed, Oct 30, 2013 at 12:54:15PM -0500, Felipe Balbi wrote: > > > > > > > > > > Do you have any patches on f_sourcesink which might have caused this > > > > > bug ? > > > > > > > > No patches, but maybe out of date code. However, I'm looking > > > > at current git master, I see you clear dep->flags but I don't > > > > see any dwc3_send_gadget_ep_cmd(DWC3_DEPCMD_CLEARSTALL)? > > > > > > I just tried to add __dwc3_gadget_ep_set_halt(dep, false); > > > right before the call to __dwc3_gadget_ep_disable() > > > in dwc3_gadget_ep_disable(), it seems to fix the issue. > > > > > > It is easily reproducible using the attached Python script, it > > > should print: > > > > > > $ ./dwc3test.py > > > [Errno 32] Pipe error (expected) > > > OK > > > > > > but instead prints: > > > > > > $ ./dwc3test.py > > > [Errno 32] Pipe error (expected) > > > [Errno 32] Pipe error > > > can you send a patch to dwc3 so we can review and possibly apply ? > > I could create a patch, but I can't test it with the current upstream > version because I'm stuck with an old 3.4.x kernel and dwc3 version > (not under my control). So my idea was to make it > reproducible for you so you can create the patch and test it. > If you want you can add Reported-by: or Suggested-by:. All right, I'll add to my todo for this week ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
