Sebastian,
On Mon, Nov 4, 2013 at 11:40 AM, Bin Liu <binmlist@xxxxxxxxx> wrote:
> Sebastian,
>
> On Mon, Nov 4, 2013 at 11:13 AM, Sebastian Andrzej Siewior
> <bigeasy@xxxxxxxxxxxxx> wrote:
>> On 10/30/2013 03:38 PM, Bin Liu wrote:
>>> Only start the otg_timer in dual role mode; otherwise in peripheral mode
>>> when musb is disconnected from the host port, otg_timer starts and
>>> continuously toggles the session, which causes VBUS pulse.
>>
>> Hmm. Okay, so one piece of the pulsing should be gone since 24616eb
>> ("usb: musb: dsps: run the timer only on OTG systems"). Now you have
>> still the pulsing in device only mode coming from the irq routine
>> itself. It would be nice if we could get rid of it but then probably
>> something else fails…
>
> I don't think the problem is in anywhere else other than where this
> patch tries to fix.
>
> The pulses only start to happen after MUSB in device mode got
> disconnected from host, due to otg_timer is set in dsps_interrupt()
> regardless the role mode is.
Sorry, please ignore my message above. I misinterpreted your response.
Yeah, probably not easy to get rid of starting otg_timer in
dsps_interrupt(), otg mode still needs it.
-Bin.
>
> Regards,
> -Bin.
>
>>
>> Acked-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
>>
>>> Signed-off-by: Bin Liu <b-liu@xxxxxx>
>>
>> Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
