Joe Perches <joe@xxxxxxxxxxx> writes:
> You did most all the multi-line statement
> alignment perfectly but missed a couple.
Damn! OK, that will teach me to do "checkpatch --strict" before
submitting.
> Maybe in a follow-on patch.
Yes, I'll fix this when I get around to the next series for this driver.
Thanks.
Bjørn
>> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
> []
>> @@ -1031,17 +1035,13 @@ cdc_ncm_speed_change(struct usbnet *dev,
>> * device speed. Do print it instead.
>> */
>> if ((tx_speed > 1000000) && (rx_speed > 1000000)) {
>> - printk(KERN_INFO KBUILD_MODNAME
>> - ": %s: %u mbit/s downlink "
>> - "%u mbit/s uplink\n",
>> - dev->net->name,
>> + netif_info(dev, link, dev->net,
>> + "%u mbit/s downlink %u mbit/s uplink\n",
>> (unsigned int)(rx_speed / 1000000U),
>> (unsigned int)(tx_speed / 1000000U));
>> } else {
>> - printk(KERN_INFO KBUILD_MODNAME
>> - ": %s: %u kbit/s downlink "
>> - "%u kbit/s uplink\n",
>> - dev->net->name,
>> + netif_info(dev, link, dev->net,
>> + "%u kbit/s downlink %u kbit/s uplink\n",
>> (unsigned int)(rx_speed / 1000U),
>> (unsigned int)(tx_speed / 1000U));
>> }
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
