On Fri, 1 Nov 2013, David Laight wrote: > > Subject: Re: [PATCH] usb: xhci: Less verbose tracing of short receives > > > > On Thu, 31 Oct 2013, David Laight wrote: > > > > > Only receive TD can have a transfer length less than the transfer size, > > > > Without commenting on the patch itself, let me point out that this > > statement is wrong. An OUT transfer can terminate early for several > > reasons. They are all error conditions, however, whereas an IN > > transfer can terminate early without any error. > > That is a bit of a nit-pick. Certainly it's a nit-pick. Nevertheless, you should strive not to confuse people by putting false statements in your patch descriptions. > The TRB completion code of 'Short packet' (13) only applies to > IN transfers, if all the data of a OUT transfer isn't sent then a > different error code is returned. Then say that instead: Only TRBs belonging to a receive TD can get a completion code of 'Short packet'. (If the data of an OUT transfer isn't all sent then a different completion code is returned.) Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
