Re: [PATCH 1/1] usb: hcd: move controller wakeup setting initialization to individual driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 30, 2013 at 11:19:12AM -0400, Alan Stern wrote:
> On Wed, 30 Oct 2013, Peter Chen wrote:
> 
> > Individual controller driver has different requirement for wakeup
> > setting, so move it from core to itself. In order to align with
> > current etting the default wakeup setting is enabled (except for
> > chipidea host).
> > 
> > Pass compile test with below commands:
> > 	make O=outout/all allmodconfig
> > 	make -j$CPU_NUM O=outout/all drivers/usb
> > 
> > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > ---
> >  drivers/usb/c67x00/c67x00-hcd.c      |    1 +
> >  drivers/usb/core/hcd-pci.c           |    2 ++
> >  drivers/usb/core/hcd.c               |    6 ------
> >  drivers/usb/gadget/dummy_hcd.c       |    2 ++
> >  drivers/usb/host/ehci-atmel.c        |    1 +
> >  drivers/usb/host/ehci-exynos.c       |    1 +
> >  drivers/usb/host/ehci-fsl.c          |    1 +
> >  drivers/usb/host/ehci-grlib.c        |    1 +
> >  drivers/usb/host/ehci-mv.c           |    1 +
> >  drivers/usb/host/ehci-mxc.c          |    1 +
> >  drivers/usb/host/ehci-octeon.c       |    1 +
> >  drivers/usb/host/ehci-omap.c         |    1 +
> >  drivers/usb/host/ehci-orion.c        |    1 +
> >  drivers/usb/host/ehci-platform.c     |    1 +
> >  drivers/usb/host/ehci-pmcmsp.c       |    4 +++-
> >  drivers/usb/host/ehci-ppc-of.c       |    1 +
> >  drivers/usb/host/ehci-ps3.c          |    1 +
> >  drivers/usb/host/ehci-sead3.c        |    1 +
> >  drivers/usb/host/ehci-sh.c           |    1 +
> >  drivers/usb/host/ehci-spear.c        |    1 +
> >  drivers/usb/host/ehci-tegra.c        |    1 +
> >  drivers/usb/host/ehci-tilegx.c       |    1 +
> >  drivers/usb/host/ehci-w90x900.c      |    1 +
> >  drivers/usb/host/ehci-xilinx-of.c    |    4 +++-
> >  drivers/usb/host/fhci-hcd.c          |    1 +
> >  drivers/usb/host/fotg210-hcd.c       |    1 +
> >  drivers/usb/host/fusbh200-hcd.c      |    1 +
> >  drivers/usb/host/hwa-hc.c            |    1 +
> >  drivers/usb/host/imx21-hcd.c         |    1 +
> >  drivers/usb/host/isp116x-hcd.c       |    1 +
> >  drivers/usb/host/isp1362-hcd.c       |    1 +
> >  drivers/usb/host/isp1760-hcd.c       |    1 +
> >  drivers/usb/host/ohci-at91.c         |    4 +++-
> >  drivers/usb/host/ohci-da8xx.c        |    2 ++
> >  drivers/usb/host/ohci-exynos.c       |    1 +
> >  drivers/usb/host/ohci-jz4740.c       |    1 +
> >  drivers/usb/host/ohci-nxp.c          |    4 +++-
> >  drivers/usb/host/ohci-octeon.c       |    1 +
> >  drivers/usb/host/ohci-omap.c         |    1 +
> >  drivers/usb/host/ohci-omap3.c        |    1 +
> >  drivers/usb/host/ohci-platform.c     |    1 +
> >  drivers/usb/host/ohci-ppc-of.c       |    4 +++-
> >  drivers/usb/host/ohci-ps3.c          |    1 +
> >  drivers/usb/host/ohci-pxa27x.c       |    4 +++-
> >  drivers/usb/host/ohci-s3c2410.c      |    1 +
> >  drivers/usb/host/ohci-sa1111.c       |    4 +++-
> >  drivers/usb/host/ohci-sm501.c        |    1 +
> >  drivers/usb/host/ohci-spear.c        |    4 +++-
> >  drivers/usb/host/ohci-tilegx.c       |    1 +
> >  drivers/usb/host/ohci-tmio.c         |    1 +
> >  drivers/usb/host/oxu210hp-hcd.c      |    1 +
> >  drivers/usb/host/r8a66597-hcd.c      |    1 +
> >  drivers/usb/host/sl811-hcd.c         |    1 +
> >  drivers/usb/host/u132-hcd.c          |    1 +
> >  drivers/usb/host/uhci-grlib.c        |    1 +
> >  drivers/usb/host/uhci-platform.c     |    1 +
> >  drivers/usb/host/whci/hcd.c          |    1 +
> >  drivers/usb/host/xhci-pci.c          |    1 +
> >  drivers/usb/host/xhci-plat.c         |    2 ++
> >  drivers/usb/musb/musb_host.c         |    1 +
> >  drivers/usb/phy/phy-msm-usb.c        |    1 +
> >  drivers/usb/phy/phy-mv-usb.c         |    6 ++++--
> >  drivers/usb/renesas_usbhs/mod_host.c |    1 +
> >  63 files changed, 85 insertions(+), 16 deletions(-)
> 
> You missed a few under drivers/staging and drivers/usb/wusbcore.

> 
> Also, it isn't necessary to add the call to dummy-hcd.c.  The 
> controller in dummy-hcd is merely an emulated device, so it's not 
> capable of generating wakeup events.
> 
> Alan Stern
> 
> 
drivers/usb/wusbcore driver has not called usb_add_hcd
Will change others, and send v2.

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux