Re: [RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[ adding Andy and Joe ]

On Thu, Oct 24, 2013 at 12:36 AM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> Permit list_for_each redifinitions like:
>
> #define for_each_connector_peer(peer, port, c) \
>        list_for_each_entry(peer, &(c)->ports, node) \
>                if (port != peer)
>
> ...which triggers:
> ERROR: Macros with complex values should be enclosed in parenthesis
>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Joe Perches <joe@xxxxxxxxxxx>
> Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
>  scripts/checkpatch.pl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 66cad506b8a2..efaf92a43c2f 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3492,6 +3492,7 @@ sub process {
>                             $dstat !~ /^for\s*$Constant$/ &&                            # for (...)
>                             $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ &&   # for (...) bar()
>                             $dstat !~ /^do\s*{/ &&                                      # do {...
> +                           $dstat !~ /^list_for_each$Ident($Constant)/ &&              # list_for_each.*(...)
>                             $dstat !~ /^\({/ &&                                         # ({...
>                             $ctx !~ /^.\s*#\s*define\s+TRACE_(?:SYSTEM|INCLUDE_FILE|INCLUDE_PATH)\b/)
>                         {
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux