Re: [PATCH v3] ARM: omap: edma: add suspend suspend/resume hooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/09/2013 10:14 PM, Joel Fernandes wrote:
> On 10/09/2013 09:12 AM, Joel Fernandes wrote:
>> On 10/09/2013 02:38 AM, Daniel Mack wrote:
> [..]
>>> (And the 'v3' in the subject is really my bad, sorry - I only sent one
>>> version of this patch ever).
>>>
>>> I can respin the patch on top of the proper driver once all the edma
>>> bits have eventually been moved to drivers/dma. Is anyone continuing
>>> Matt Porter's work on this?
>>
>> The work is waiting on conversion of the davinci-pcm ASoC driver to DMA Engine,
>> which once done can make exposing the private EDMA API in arch/arm/common/edma.c
>> obsolete and we can take it to drivers/dma. Some more work to be done in edma in
>> unifying the probe etc.
> 
> Forgot to mention, since ASoC DMAengine conversion is not going to happen any
> time soon considering the amount of work involved, I suggest you respin this
> patch on the common/edma code itself. That way we can keep suspend/resume
> working on these platforms that use EDMA till the actual conversion takes place.

Ok, I also figured that the current patch does not really suffice. There
seems to be an issue with omap_hsmmc DMA channels being disfunct after
resume, so I'll respin it.

> I suggest though to recreate the state based on existing datastructures instead
> of allocating/saving additional memory.
> 
> Hope you're also in agreement with my comments on your original patch on what
> needs to / need not be saved.

I'm still not sure whether the parameters block has to be preserved
manually. Let see what we're left with eventually :)


Thanks,
Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux