On Thu, 17 Oct 2013, Majunath Goudar wrote:
> Suspend scenario in case of ohci-at91 glue was not properly handled
> as it was not suspending generic part of ohci controller. Alan Stern
> suggested, properly handle ohci-at91 suspend scenario.
>
> Calling explicitly the ohci_suspend() routine in ohci_hcd_at91_drv_suspend()
> will ensure proper handling of suspend scenario. This task is sugested
> by Alan Stern.
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -636,8 +636,14 @@ ohci_hcd_at91_drv_suspend(struct platform_device *pdev, pm_message_t mesg)
> {
> struct usb_hcd *hcd = platform_get_drvdata(pdev);
> struct ohci_hcd *ohci = hcd_to_ohci(hcd);
> + bool do_wakeup = device_may_wakeup(&pdev->dev);
> + int ret;
>
> - if (device_may_wakeup(&pdev->dev))
> + ret = ohci_suspend(hcd, do_wakeup);
> + if (ret)
> + return ret;
> +
> + if (do_wakeup)
> enable_irq_wake(hcd->irq);
I believe the ohci_suspend call should come after the enable_irq_wake
part, not before it. (Have we discussed this before? I can't
remember.)
Of course, this means you may have to call disable_irq_wake if
ohci_suspend fails.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
