Re: [PATCH 1/2] usb: ohci-pxa27x: add regulator support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 16 Oct 2013, Nikita Kiryanov wrote:

> Add regulator support for usb so that it would be possible to turn
> it on and off (also for suspend/resume).
> 
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Nikita Kiryanov <nikita@xxxxxxxxxxxxxx>
> Signed-off-by: Igor Grinberg <grinberg@xxxxxxxxxxxxxx>


> @@ -413,10 +420,16 @@ int usb_hcd_pxa27x_probe (const struct hc_driver *driver, struct platform_device
>  	ohci->dev = &pdev->dev;
>  	ohci->clk = usb_clk;
>  	ohci->mmio_base = (void __iomem *)hcd->regs;
> +	ohci->usb_regulator = regulator_get(&pdev->dev, "vcc usb");
> +	if (IS_ERR(ohci->usb_regulator)) {
> +		pr_err("could not obtain usb regulator");

dev_err(), please.

> +		retval = PTR_ERR(ohci->usb_regulator);
> +		goto err3;
> +	}
>  
>  	if ((retval = pxa27x_start_hc(ohci, &pdev->dev)) < 0) {
>  		pr_debug("pxa27x_start_hc failed");
> -		goto err3;
> +		goto err4;
>  	}
>  
>  	/* Select Power Management Mode */

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux