On Mon, 14 Oct 2013, Michael Opdenacker wrote: > Hi Alan, > > On 10/13/2013 05:35 PM, Alan Stern wrote: > > On Sun, 13 Oct 2013, Michael Opdenacker wrote: > > > >> Remove the use of local_irq_save() and IRQF_DISABLED, no longer needed since > >> interrupt handlers are always run with interrupts disabled on the > >> current CPU. > >> > >> Tested successfully with 3.12.0-rc4 on my PC. Didn't find > >> any issue because of this change. > >> > >> Signed-off-by: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxxxxxxxxx> > >> --- > >> drivers/usb/core/hcd.c | 15 --------------- > >> 1 file changed, 15 deletions(-) > > How about removing all the other unnecessary usages of IRQF_DISABLED > > under drivers/usb while you're at it? > I believe I already did, through patches sent on Oct. 6: > > drivers/usb/gadget/mv_u3d_core.c: IRQF_DISABLED | > IRQF_SHARED, driver_name, u3d)) { > => Sent fix on Oct. 6, 2013 > > drivers/usb/host/uhci-platform.c: ret = usb_add_hcd(hcd, > pdev->resource[1].start, IRQF_DISABLED | > => Sent fix on Oct. 6, 2013 Ah, I had forgotten about those submissions. No further objections. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html