Re: usb_control_msg and non-dma buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 14, 2013 at 08:47:36AM -0700, Guenter Roeck wrote:
> Hi all,
> 
> I am getting the following smatch error in drivers/watchdog/pcwd_usb.c:
> 
> drivers/watchdog/pcwd_usb.c:257 usb_pcwd_send_command() error: doing dma on the stack (buf)
> 
> This is from a call to usb_control_msg().
> 
> Is this a false positive or a real problem that needs to be fixed ?

It is a real problem that must be fixed.

You can't send USB data off of the stack and expect the driver to work
on all controllers and platforms.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux