On Mon, Oct 14, 2013 at 05:09:55PM +0800, Shawn Guo wrote:
> On Sat, Oct 12, 2013 at 05:09:36PM +0800, Peter Chen wrote:
> > After adding IC fixes bits, some PHY bugs are fixed by
> > IC logic.
> >
> > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > ---
> > drivers/usb/phy/phy-mxs-usb.c | 10 ++++++++++
> > 1 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> > index 87ba429..831b13e 100644
> > --- a/drivers/usb/phy/phy-mxs-usb.c
> > +++ b/drivers/usb/phy/phy-mxs-usb.c
> > @@ -29,6 +29,10 @@
> > #define HW_USBPHY_CTRL_SET 0x34
> > #define HW_USBPHY_CTRL_CLR 0x38
> >
> > +#define HW_USBPHY_IP 0x90
> > +#define HW_USBPHY_IP_SET 0x94
> > +#define HW_USBPHY_IP_CLR 0x98
> > +
> > #define BM_USBPHY_CTRL_SFTRST BIT(31)
> > #define BM_USBPHY_CTRL_CLKGATE BIT(30)
> > #define BM_USBPHY_CTRL_ENAUTOSET_USBCLKS BIT(26)
> > @@ -40,6 +44,8 @@
> > #define BM_USBPHY_CTRL_ENUTMILEVEL2 BIT(14)
> > #define BM_USBPHY_CTRL_ENHOSTDISCONDETECT BIT(1)
> >
> > +#define BM_USBPHY_IP_FIX (BIT(17) | BIT(18))
> > +
> > #define to_mxs_phy(p) container_of((p), struct mxs_phy, phy)
> >
> > enum imx_phy_type {
> > @@ -118,6 +124,10 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)
> > BM_USBPHY_CTRL_ENUTMILEVEL3,
> > base + HW_USBPHY_CTRL_SET);
> >
> > + /* Enable IC solution */
> > + if (is_mx6q_phy(mxs_phy) || is_mx6sl_phy(mxs_phy))
>
> Am I missing any dependency/patches here? Where were is_mx6q_phy() and
> is_mx6sl_phy() introduced?
>
> Shawn
>
> > + writel(BM_USBPHY_IP_FIX, base + HW_USBPHY_IP_SET);
> > +
> > return 0;
> > }
> >
> > --
> > 1.7.1
> >
> >
Oh, sorry. I forget to put below one to this serial.
Will do at v2
http://marc.info/?l=linux-usb&m=137871552016298&w=2
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
