Re: [PATCH 0/6] drivers: usb: core: Adapt source to styleguide

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 10, 2013 at 11:41:26PM +0200, Matthias Beyer wrote:
> Hi,
> 
> I patches several files in drivers/usb/core/ to adapt them to the kernel
> styleguide.
> 
> Most of these patches are whitespace/indention fixes.
> 
> As these patches are only style-patches, I just compiled the kernel, no compile
> errors or warnings. So I think everything seems to be okay!
> 
> Note: I did not fix all ERROR messages from the scripts/checkpatch.pl script, as
> I don't know what to do with "do not use assignments in if-condition" messages.

You can fix those up if you want.  An example would be:
	bad code:
		if ((x = foo() == NULL)
			do_something();
	good code:
		x = foo();
		if (x == NULL)
			do_something();

Hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux