On Wed, Oct 09, 2013 at 09:54:54PM +0200, Andrew Lunn wrote: > On Wed, Oct 09, 2013 at 07:27:42PM +0200, Johan Hovold wrote: > > This should probably remain a device-specific parameter. We already have > > the MOXA mxser-driver with similar configuration options. This one uses > > a custom ioctl to set the interface, but I think we should use a sysfs > > parameter for this. > > > > What do you say about a simple "interface"-parameter representing the > > four MX_INT-values above? A string parameter would perhaps be even > > better if you combine it with an "interface_available"-parameter, for > > example: > > > > # cat /sys/bus/usb-serial/devices/ttyUSB0/interface_available > > rs232 rs422 rs485-2w rs485-4w > > > > for devices which can use all four modes. > > > > Sorry about the confusion. > > Hi Johan > > No problems. > > I'm actually tempted to drop the support for anything over than RS232. > That is all the hardware i have can do. So anything we do add i cannot > test. > > If somebody does have the necessary hardware and the need for these > extra modes we can come back to this. That's up to you to decide. You got most of the required structure in place already (e.g. the rs232-only quirk) so it need not be much additional work (whenever it's implemented). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
