On Thursday, October 10, 2013 3:49 PM, Sachin Kamat wrote: > On 10 October 2013 12:01, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: > > The non-DT for EXYNOS SoCs is not supported from v3.11. > > Thus, there is no need to support non-DT for Exynos EHCI driver. > > > > The 'include/linux/platform_data/usb-ehci-exynos.h' file has been > > used for non-DT support. Thus, the 'usb-ehci-exynos.h' file can > > be removed. > > Wouldn't it be better to do the non-DT cleanup first and then the renaming. > This would avoid unnecessary code churn. For e.g., since the header file is > deleted in this patch, it doesn't make sense to rename the file and > other variable/function > names in the previous patch. Hi Sachin Kamat, OK, I see. I will do the non-DT cleanup first and then the renaming, as you mentioned. Then, the v2 patches will be as below: [PATCH 1/5] ARM: SAMSUNG: Remove unused s5p_device_ehci [PATCH 2/5] USB: ehci-s5p: Remove non-DT support [PATCH 3/5] USB: ohci-exynos: Remove non-DT support [PATCH 4/5] USB: host: Rename ehci-s5p to ehci-exynos [PATCH 5/5] USB: ohci-exynos: Add missing usb_put_hcd() Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html