Re: [PATCH 4/5] usb: xhci: Staticize xhci_del_comp_mod_timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 09, 2013 at 03:15:31PM -0700, Sarah Sharp wrote:
> On Wed, Oct 09, 2013 at 01:10:47PM -0700, Greg Kroah-Hartman wrote:
> > On Wed, Oct 09, 2013 at 12:53:51PM -0700, Sarah Sharp wrote:
> > > From: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> > > 
> > > 'xhci_del_comp_mod_timer' is local to this file.
> > > 
> > > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> > > Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> > > ---
> > >  drivers/usb/host/xhci-hub.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
> > > index e8b4c56..45ca532 100644
> > > --- a/drivers/usb/host/xhci-hub.c
> > > +++ b/drivers/usb/host/xhci-hub.c
> > > @@ -524,7 +524,8 @@ static void xhci_hub_report_usb3_link_state(u32 *status, u32 status_reg)
> > >   * the compliance mode timer is deleted. A port won't enter
> > >   * compliance mode if it has previously entered U0.
> > >   */
> > > -void xhci_del_comp_mod_timer(struct xhci_hcd *xhci, u32 status, u16 wIndex)
> > > +static void xhci_del_comp_mod_timer(struct xhci_hcd *xhci, u32 status,
> > > +				    u16 wIndex)
> > 
> > This doesn't need to go into 3.12, as it isn't a bugfix or regression,
> > as you stated in your pull request, why did you include it?
> 
> Meh, I thought it was a trivial fix, but you're right, it should go into
> 3.13.
> 
> > I can just take these patches individually, instead of as a pull
> > request, so that this one doesn't come in, is that ok?
> 
> Sure.  I can also send you a second pull request, no biggie. :)

Second request would be great please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux