Hi Sergei, (replying from my personal e-mail) On Sun, Oct 6, 2013 at 3:02 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > > Hello. > > On 05-10-2013 0:30, David Cohen wrote: > >> If USB_FUNCTIONFS is selected without USB_FUNCTIONFS_ETH and >> USB_FUNCTIONFS_RNIS, u_ether.h won't be included and then >> USB_ETHERNET_MODULE_PARAMAETERS macro won't be available causing the >> following warning compilation: > > >> drivers/usb/gadget/g_ffs.c:81:1: warning: data definition has no type or >> storage class [enabled by default] >> drivers/usb/gadget/g_ffs.c:81:1: warning: type defaults to ‘int’ in >> declaration of ‘USB_ETHERNET_MODULE_PARAMETERS’ [-Wimplicit-int] >> drivers/usb/gadget/g_ffs.c:81:1: warning: function declaration isn’t a >> prototype [-Wstrict-prototypes] > > >> This patch fixes the warning by making USB_ETHERNET_MODULE_PARAMETERS to >> be used iff u_ether.h is included, otherwise it is not needed. > > >> Signed-off-by: David Cohen <david.a.cohen@xxxxxxxxxxxxxxx> >> --- >> drivers/usb/gadget/g_ffs.c | 2 ++ >> 1 file changed, 2 insertions(+) > > >> diff --git a/drivers/usb/gadget/g_ffs.c b/drivers/usb/gadget/g_ffs.c >> index 5327c82..2344efe 100644 >> --- a/drivers/usb/gadget/g_ffs.c >> +++ b/drivers/usb/gadget/g_ffs.c >> @@ -76,7 +76,9 @@ struct gfs_ffs_obj { >> >> USB_GADGET_COMPOSITE_OPTIONS(); >> >> +#if defined CONFIG_USB_FUNCTIONFS_ETH || defined CONFIG_USB_FUNCTIONFS_RNDIS > > > I thought the 'defined' operator requires ()? I though the same. But I copied this line from this same file when it's deciding whether to include u_ether.h or not. BR, David Cohen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html