On Sat, 5 Oct 2013, Greg KH wrote: > On Fri, Oct 04, 2013 at 10:40:45AM -0500, Thomas Pugliese wrote: > > This patch adds support for isochronous out transfers to the HWA. The > > primary changes are: > > > > 1. Add a isoc_pack_desc_urb field to struct wa_seg. This urb is used > > to send the isochronous packet info message to the HWA which describes > > the isoc data segment(s) that will be sent as the payload of the > > transfer request. > > > > 2. Use the URB iso_frame_desc field to populate the isochronous packet > > info message and data segments sent to the HWA. > > > > 3. After the data is sent and transfer result is returned from the > > HWA, read the isoc packet status message from the HWA. The contents of > > the isoc packet status message are used to set the iso_frame_desc > > status and actual_length fields in the original isoc URB. This feature > > required the addition of a some state tracking variables in struct wahc > > so the dti_urb knows what type of packet it expects to receive next. > > > > > > Signed-off-by: Thomas Pugliese <thomas.pugliese@xxxxxxxxx> > > --- > > drivers/usb/wusbcore/wa-hc.h | 15 ++ > > drivers/usb/wusbcore/wa-xfer.c | 493 +++++++++++++++++++++++++++++++--------- > > 2 files changed, 406 insertions(+), 102 deletions(-) > > Nice job, I've applied this, but I'm getting build warnings again, you > should really try to test your changes on a 64bit box: > > drivers/usb/wusbcore/wa-xfer.c: In function ‘__wa_xfer_setup_sizes’: > drivers/usb/wusbcore/wa-xfer.c:475:5: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat] > drivers/usb/wusbcore/wa-xfer.c: In function ‘wa_process_iso_packet_status’: > drivers/usb/wusbcore/wa-xfer.c:1924:4: warning: format ‘%zu’ expects argument of type ‘size_t’, but argument 4 has type ‘int’ [-Wformat] > > Can you send a follow-on patch fixing this up? > > thanks, > > greg k-h > Yes. I really need to switch to using my 64-bit machine by default. I had these fixed but I forgot to merge them before submitting. I will send a follow on patch that fixes the warnings. Thanks, Tom
